Support contentless activity in livestream#5430
Merged
compulim merged 54 commits intomicrosoft:mainfrom Mar 12, 2025
Merged
Conversation
2dc4c3d to
666d7c1
Compare
OEvgeny
reviewed
Mar 12, 2025
OEvgeny
reviewed
Mar 12, 2025
OEvgeny
reviewed
Mar 12, 2025
OEvgeny
reviewed
Mar 12, 2025
OEvgeny
reviewed
Mar 12, 2025
__tests__/html2/livestream/raceBetweenTypingAndContentlessLivestream.html
Outdated
Show resolved
Hide resolved
OEvgeny
reviewed
Mar 12, 2025
packages/api/src/providers/ActivityTyping/private/useReduceActivities.ts
Show resolved
Hide resolved
OEvgeny
reviewed
Mar 12, 2025
packages/api/src/providers/ActivityTyping/private/useReduceActivities.ts
Show resolved
Hide resolved
OEvgeny
previously approved these changes
Mar 12, 2025
OEvgeny
previously approved these changes
Mar 12, 2025
Collaborator
OEvgeny
left a comment
There was a problem hiding this comment.
Approved with another question
OEvgeny
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
This PR will add support of contentless activity in livestream.
Contentless activity are activities that will not be rendered. It includes activities without
textandattachments.In a livestream, activity without text content and attachments will be rendered as typing indicator and would not fade away until the livestream concluded.
When a livestream is concluded with a contentless activity, its message bubble will be removed.
Contentless activity in livestream
Contentless activity in livestream will show up as a typing indicator that will only go away when the livestream is concluded.
Design
Currently, contentless activity includes only activities without
textandattachments. In future, we may consider activities which are not rendered by any activity and attachment middleware as well.Specific Changes
"contentless"useReduceActivitieshook to process incremental changes to activitiesuseReduceActivitiesto enable incremental computationuseActivities()state hook is updated, it will recompute from the position where the change occurreduseReduceActivitiesLIVESTREAMING.md<WebChatDecorator>to all tests related to livestreaming__tests__/sendTypingIndicatorto "html2".eslintrcconversationStartProperties.*renderHooknot working with props in rerenderCHANGELOG.mdReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)